linux-kernel - Re: [PATCH v9 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMntRILEO3ceyeZU@kroah.com>
Date:   Wed, 16 Jun 2021 14:23:32 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sanjay R Mehta <sanmehta@....com>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Sanjay R Mehta <Sanju.Mehta@....com>,
        dan.j.williams@...el.com, Thomas.Lendacky@....com,
        Shyam-sundar.S-k@....com, Nehal-bakulchandra.Shah@....com,
        robh@...nel.org, mchehab+samsung@...nel.org, davem@...emloft.net,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v9 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

On Wed, Jun 16, 2021 at 05:30:49PM +0530, Sanjay R Mehta wrote:
> The pt_device is allocated and initialized in the PCI probe function and
> then we just get the "dev" from the "pci_dev" object and save it in
> "pt->dev" as shown in below snippet.
> 
> 
>    static int pt_pci_probe(struct pci_dev *pdev, const struct
> pci_device_id *id)
>    {
> 	struct pt_device *pt;
> 	struct pt_msix *pt_msix;
> 	struct device *dev = &pdev->dev;

So "dev" is a parent here, or something else?

If it is the parent, please call it such otherwise it is confusing.

If you are creating child devices, what bus do they belong to?

Can you fix up this series and resend it so that we can review it again?

thanks,

greg k-h