linux-kernel - Re: [PATCH v7 1/5] string_helpers: Escape double quotes in escape

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210616093042.2036ef2c@gandalf.local.home>
Date:   Wed, 16 Jun 2021 09:30:42 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Chris Down <chris@...isdown.name>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Petr Mladek <pmladek@...e.com>, Jessica Yu <jeyu@...nel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        John Ogness <john.ogness@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Kees Cook <keescook@...omium.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>, kernel-team@...com
Subject: Re: [PATCH v7 1/5] string_helpers: Escape double quotes in
 escape_special

On Wed, 16 Jun 2021 11:08:18 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Tue, Jun 15, 2021 at 07:05:25PM -0700, Randy Dunlap wrote:
> > On 6/15/21 5:00 PM, Chris Down wrote:  
> > > Andy Shevchenko writes:  
> > >>> I've checked uses of ESCAPE_SPECIAL and %pE across the codebase, and I'm  
> > >>
> > >> checked the uses  
> > > 
> > > Hmm, what's wrong with using the zero article for "checked uses"? I mean, I don't have any strong resistance, but I don't see anything wrong with it either, and it matches how I'd naturally speak.
> > > 
> > > Agreed on the others, though, hopefully they can be massaged in :-)  
> > 
> > Ack, I don't see anything wrong with it either.  
> 
> I guess you know better than me :-)
> 
> I'm just a mere non-native speaker here to whom it's stylistically harder to
> parse without the article.

English is weird. It sounds fine to me with and without the "the" article,
but I'll say having "the" does make it a little smoother, and probably
better for the non-native speaking folks.

Technically, I'm a native speaker, but I prefer to say my mother tongue is C. ;-)

-- Steve