linux-kernel - Re: [PATCH -next] drm/amd/display: Fix gcc unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa86062f-cb45-245b-1bf0-494ffcd33908@amd.com>
Date:   Thu, 17 Jun 2021 14:42:52 -0400
From:   Harry Wentland <harry.wentland@....com>
To:     Pu Lehui <pulehui@...wei.com>, sunpeng.li@....com,
        alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...ux.ie, daniel@...ll.ch,
        Jun.Lei@....com, wenjing.liu@....com, Anson.Jacob@....com,
        qingqing.zhuo@....com, Wesley.Chalmers@....com,
        Jimmy.Kizito@....com, aric.cyr@....com, martin.tsai@....com,
        jinlong.zhang@....com
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, zhangjinhao2@...wei.com
Subject: Re: [PATCH -next] drm/amd/display: Fix gcc unused variable warning

On 2021-06-16 10:31 p.m., Pu Lehui wrote:
> GCC reports the following warning with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3635:17:
> warning:
>  variable ‘status’ set but not used [-Wunused-but-set-variable]
>   3635 |  enum dc_status status = DC_ERROR_UNEXPECTED;
>        |                 ^~~~~~
> 
> The variable should be used for error check, let's fix it.
> 
> Signed-off-by: Pu Lehui <pulehui@...wei.com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index fcb635c85330..cf29265870c8 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -3681,6 +3681,10 @@ bool dp_retrieve_lttpr_cap(struct dc_link *link)
>  				DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV,
>  				lttpr_dpcd_data,
>  				sizeof(lttpr_dpcd_data));
> +		if (status != DC_OK) {
> +			dm_error("%s: Read LTTPR caps data failed.\n", __func__);
> +			return false;
> +		}
>  
>  		link->dpcd_caps.lttpr_caps.revision.raw =
>  				lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV -
>