| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210617112400.5e68c172@zhouyanjie-virtual-machine>
Date: Thu, 17 Jun 2021 11:24:00 +0800
From: 周琰杰 <zhouyanjie@...yeetech.com>
To: Rob Herring <robh+dt@...nel.org>, sihui.liu@...enic.com
Cc: David Miller <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Giuseppe CAVALLARO <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Alexandre Torgue <alexandre.torgue@...com>,
netdev <netdev@...r.kernel.org>, devicetree@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@...md-mailman.stormreply.com>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>, dongsheng.qiu@...enic.com,
aric.pzqi@...enic.com, rick.tyliu@...enic.com,
jun.jiang@...enic.com, sernia.zhou@...mail.com
Subject: Re: [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic
SoCs.
Hi Rob,
于 Wed, 16 Jun 2021 15:45:26 +0800
周琰杰 <zhouyanjie@...yeetech.com> 写道:
> Hi Rob,
>
> 于 Tue, 15 Jun 2021 17:05:45 -0600
> Rob Herring <robh+dt@...nel.org> 写道:
>
> > On Mon, Jun 14, 2021 at 11:18 AM 周琰杰 (Zhou Yanjie)
> > <zhouyanjie@...yeetech.com> wrote:
> > >
> > > Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,
> > > the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.
> > >
> > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> > > ---
> > >
> > > Notes:
> > > v1->v2:
> > > No change.
> > >
> > > v2->v3:
> > > Add "ingenic,mac.yaml" for Ingenic SoCs.
> > >
> > > .../devicetree/bindings/net/ingenic,mac.yaml | 76
> > > ++++++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml
> > > | 15 +++++ 2 files changed, 91 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/net/ingenic,mac.yaml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/net/ingenic,mac.yaml
> > > b/Documentation/devicetree/bindings/net/ingenic,mac.yaml new file
> > > mode 100644 index 00000000..5fe2e81 --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
> > > @@ -0,0 +1,76 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/net/ingenic,mac.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Bindings for MAC in Ingenic SoCs
> > > +
> > > +maintainers:
> > > + - 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> > > +
> > > +description:
> > > + The Ethernet Media Access Controller in Ingenic SoCs.
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - ingenic,jz4775-mac
> > > + - ingenic,x1000-mac
> > > + - ingenic,x1600-mac
> > > + - ingenic,x1830-mac
> > > + - ingenic,x2000-mac
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + interrupts:
> > > + maxItems: 1
> > > +
> > > + interrupt-names:
> > > + const: macirq
> > > +
> > > + clocks:
> > > + maxItems: 1
> > > +
> > > + clock-names:
> > > + const: stmmaceth
> > > +
> > > + mode-reg:
> > > + description: An extra syscon register that control ethernet
> > > interface and timing delay
> >
> > Needs a vendor prefix and type.
> >
> > > +
> > > + rx-clk-delay-ps:
> > > + description: RGMII receive clock delay defined in pico
> > > seconds +
> > > + tx-clk-delay-ps:
> > > + description: RGMII transmit clock delay defined in pico
> > > seconds +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - interrupts
> > > + - interrupt-names
> > > + - clocks
> > > + - clock-names
> > > + - mode-reg
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + #include <dt-bindings/clock/x1000-cgu.h>
> > > +
> > > + mac: ethernet@...b0000 {
> > > + compatible = "ingenic,x1000-mac", "snps,dwmac";
> >
> > Doesn't match the schema.
>
> Sorry for that, somehow when I run "make dt_bindings_check", there is
> no warrning or error message about this file. I am sure that yamllint
> is installed and dtschema has been upgraded to 2021.6.
I found that it seems to be because 5.13 newly introduced
"DT_CHECKER_FLAGS=-m", and I am still using the old
"make dt_binding_check" command, so this error is not prompted. Now I
can see this error message after using the
"make DT_CHECKER_FLAGS=-m dt_binding_check" command, and I will send a
fix soon.
Thanks and best regards!
>
> I will send a fix.
>
> Thanks and best regards!
>
> >
> > > + reg = <0x134b0000 0x2000>;
> > > +
> > > + interrupt-parent = <&intc>;
> > > + interrupts = <55>;
> > > + interrupt-names = "macirq";
> > > +
> > > + clocks = <&cgu X1000_CLK_MAC>;
> > > + clock-names = "stmmaceth";
> > > +
> > > + mode-reg = <&mac_phy_ctrl>;
> > > + };
> > > +...
> > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index
> > > 2edd8be..9c0ce92 100644 ---
> > > a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++
> > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -56,6
> > > +56,11 @@ properties:
> > > - amlogic,meson8m2-dwmac
> > > - amlogic,meson-gxbb-dwmac
> > > - amlogic,meson-axg-dwmac
> > > + - ingenic,jz4775-mac
> > > + - ingenic,x1000-mac
> > > + - ingenic,x1600-mac
> > > + - ingenic,x1830-mac
> > > + - ingenic,x2000-mac
> > > - rockchip,px30-gmac
> > > - rockchip,rk3128-gmac
> > > - rockchip,rk3228-gmac
> > > @@ -310,6 +315,11 @@ allOf:
> > > - allwinner,sun8i-r40-emac
> > > - allwinner,sun8i-v3s-emac
> > > - allwinner,sun50i-a64-emac
> > > + - ingenic,jz4775-mac
> > > + - ingenic,x1000-mac
> > > + - ingenic,x1600-mac
> > > + - ingenic,x1830-mac
> > > + - ingenic,x2000-mac
> > > - snps,dwxgmac
> > > - snps,dwxgmac-2.10
> > > - st,spear600-gmac
> > > @@ -353,6 +363,11 @@ allOf:
> > > - allwinner,sun8i-r40-emac
> > > - allwinner,sun8i-v3s-emac
> > > - allwinner,sun50i-a64-emac
> > > + - ingenic,jz4775-mac
> > > + - ingenic,x1000-mac
> > > + - ingenic,x1600-mac
> > > + - ingenic,x1830-mac
> > > + - ingenic,x2000-mac
> > > - snps,dwmac-4.00
> > > - snps,dwmac-4.10a
> > > - snps,dwmac-4.20a
> > > --
> > > 2.7.4
> >
Powered by blists - more mailing lists