linux-kernel - Re: [PATCH] be2net: Fix an error handling path in 'be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOBf=msiqGHTkDosQhtsWnuprgV0uQ-LjrWnVruOSV2M8rznAQ@mail.gmail.com>
Date:   Thu, 17 Jun 2021 10:07:27 +0530
From:   Somnath Kotur <somnath.kotur@...adcom.com>
To:     christophe.jaillet@...adoo.fr
Cc:     Ajit Kumar Khaparde <ajit.khaparde@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        davem@...emloft.net, kuba@...nel.org, sathya.perla@...lex.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] be2net: Fix an error handling path in 'be_probe()'

On Thu, Jun 17, 2021 at 12:13 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: d6b6d9877878 ("be2net: use PCIe AER capability")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/ethernet/emulex/benet/be_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index b6eba29d8e99..7968568bbe21 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -5897,6 +5897,7 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
>  unmap_bars:
>         be_unmap_pci_bars(adapter);
>  free_netdev:
> +       pci_disable_pcie_error_reporting(pdev);
>         free_netdev(netdev);
>  rel_reg:
>         pci_release_regions(pdev);
> --
> 2.30.2
>
Acked-by: Somnath Kotur <somnath.kotur@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)