linux-kernel - Re: [PATCH v3 5/5] pstore/blk: Include zone in pstore_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210617075745.GC899@lst.de>
Date:   Thu, 17 Jun 2021 09:57:45 +0200
From:   Christoph Hellwig <hch@....de>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Al Viro <viro@...iv.linux.org.uk>, gmpy.liaowx@...il.com,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Jonathan Corbet <corbet@....net>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-doc@...r.kernel.org, linux-mtd@...ts.infradead.org,
        linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] pstore/blk: Include zone in pstore_device_info

On Wed, Jun 16, 2021 at 09:40:43AM -0700, Kees Cook wrote:
> Information was redundant between struct pstore_zone_info and struct
> pstore_device_info. Use struct pstore_zone_info, with member name "zone".
> 
> Additionally untangle the logic for the "best effort" block device
> instance.

I'd still prefer to kill off struct pstore_device_info, but this is
already a huge improvement:

Reviewed-by: Christoph Hellwig <hch@....de>