linux-kernel - [PATCH 1/1] hpfs: remove unnecessary oom message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210617085203.1332-1-thunder.leizhen@huawei.com>
Date:   Thu, 17 Jun 2021 16:52:03 +0800
From:   Zhen Lei <thunder.leizhen@...wei.com>
To:     Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
        linux-kernel <linux-kernel@...r.kernel.org>
CC:     Zhen Lei <thunder.leizhen@...wei.com>
Subject: [PATCH 1/1] hpfs: remove unnecessary oom message

Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
---
 fs/hpfs/dnode.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/hpfs/dnode.c b/fs/hpfs/dnode.c
index 4ada525c5c43..40edbd6c2b7e 100644
--- a/fs/hpfs/dnode.c
+++ b/fs/hpfs/dnode.c
@@ -34,10 +34,8 @@ int hpfs_add_pos(struct inode *inode, loff_t *pos)
 				return 0;
 	if (!(i&0x0f)) {
 		ppos = kmalloc_array(i + 0x11, sizeof(loff_t *), GFP_NOFS);
-		if (!ppos) {
-			pr_err("out of memory for position list\n");
+		if (!ppos)
 			return -ENOMEM;
-		}
 		if (hpfs_inode->i_rddir_off) {
 			memcpy(ppos, hpfs_inode->i_rddir_off, i * sizeof(loff_t));
 			kfree(hpfs_inode->i_rddir_off);
-- 
2.25.1