linux-kernel - Re: [PATCH v4 0/6] bootconfig: Add mixed subkeys and value under the same key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210617102706.a0317c13edc786ec490a2167@kernel.org>
Date:   Thu, 17 Jun 2021 10:27:06 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Devin Moore <devinmoore@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v4 0/6] bootconfig: Add mixed subkeys and value under
 the same key

On Wed, 16 Jun 2021 15:17:01 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Fri, 11 Jun 2021 08:56:35 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > kernel {
> >       trace_options = sym-addr
> >       trace_events = "initcall:*"
> > #      tp_printk
> >       trace_buf_size = 1M
> >       ftrace = function
> >       ftrace_filter = "vfs*"
> > }
> 
> I'm creating a ktest test for boot up on bootconfigs and writing a verifier
> for each of the configs you sent me. On the first config I looked at
> "boottrace.bconf", I found a bug.
> 
> The above should be:
> 
> 	trace_event = "initcall:*"
> 
> and not "trace_events" as "trace_events" is not a boot option ;-)

Oops, thanks!

BTW, I'm thinking to introduce more basic tests for kernel cmdlie.
For example, checking the kernel.* and init.* are merged correctly
in the /proc/cmdline.

But yes, this needs to use ktest because it sets the bootconfig
to initrd and reboots with it for testing.

Thank you,

-- 
Masami Hiramatsu <mhiramat@...nel.org>