linux-kernel - RE: Re: [PATCH] scsi: ufs: Add indent for code alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2038148563.21623893584364.JavaMail.epsvc@epcpadp4>
Date:   Thu, 17 Jun 2021 10:28:39 +0900
From:   Keoseong Park <keosung.park@...sung.com>
To:     Joe Perches <joe@...ches.com>,
        Keoseong Park <keosung.park@...sung.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "satyat@...gle.com" <satyat@...gle.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Re: [PATCH] scsi: ufs: Add indent for code alignment

>On Thu, 2021-06-10 at 13:07 +0900, Keoseong Park wrote:
>> Add indentation to return statement.
>[]
>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>[]
>> @@ -903,7 +903,7 @@ static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
>>  	else
>>  		return false;
>>  #else
>> -return true;
>> +	return true;
>>  #endif
>>  }
>>  
>
>Perhaps a little refactoring instead:
>---
> drivers/scsi/ufs/ufshcd.h | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>index c98d540ac044d..ed89839476b3b 100644
>--- a/drivers/scsi/ufs/ufshcd.h
>+++ b/drivers/scsi/ufs/ufshcd.h
>@@ -894,15 +894,11 @@ static inline bool ufshcd_is_rpm_autosuspend_allowed(struct ufs_hba *hba)
> static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
> {
> /* DWC UFS Core has the Interrupt aggregation feature but is not detectable*/
>-#ifndef CONFIG_SCSI_UFS_DWC
>-	if ((hba->caps & UFSHCD_CAP_INTR_AGGR) &&
>-	    !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR))
>+	if (IS_ENABLED(CONFIG_SCSI_UFS_DWC))
> 		return true;
>-	else
>-		return false;
>-#else
>-return true;
>-#endif
>+
>+	return (hba->caps & UFSHCD_CAP_INTR_AGGR) &&
>+		!(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR);
> }
> 
> static inline bool ufshcd_can_aggressive_pc(struct ufs_hba *hba)
>

Hello Joe,
Thanks for your advice.
As you mentioned, refactoring looks good.
However, since the content does not match the title, can I submit a patch with a new title?

Best Regards,
Keoseong