linux-kernel - Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210617120747.GB5067@sirena.org.uk>
Date:   Thu, 17 Jun 2021 13:07:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     班涛 <fengzheng923@...il.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        mripard@...nel.org, wens@...e.org, jernej.skrabec@...il.com,
        p.zabel@...gutronix.de, Samuel Holland <samuel@...lland.org>,
        krzk@...nel.org, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver

On Thu, Jun 17, 2021 at 07:50:42PM +0800, 班涛 wrote:
> Mark Brown <broonie@...nel.org> 于2021年6月17日周四 下午6:48写道：
> > On Thu, Jun 17, 2021 at 03:42:43PM +0800, 班涛 wrote:
> > > Mark Brown <broonie@...nel.org> 于2021年6月15日周二 下午9:22写道：

> > No, that's what you have already make the entire thing a C++ comment
> > with //s.

> I don’t understand. For example, sun4i-codec.c sun4i-i2s.c
> sun8i-codec.c and sun4i-spdif.c files are the same as mine.

Other people doing a bad job is no excuse for doing a bad job yourself.

> Which file can I refer to? what should I do......

Make every line of the comment start with //.  See soc-core.c

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)