linux-kernel - Re: [PATCH -next] ASoC: tegra: Add missing of_node_put() in tegra_machine_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1183fa4-2f13-d44e-20df-f8c6c847e3bd@gmail.com>
Date:   Thu, 17 Jun 2021 15:36:15 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Zou Wei <zou_wei@...wei.com>, lgirdwood@...il.com,
        broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
        thierry.reding@...il.com, jonathanh@...dia.com
Cc:     linux-tegra@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ASoC: tegra: Add missing of_node_put() in
 tegra_machine_parse_phandle()

17.06.2021 14:30, Zou Wei пишет:
> The function is missing a of_node_put on node, fix this by adding the call
> before returning.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  sound/soc/tegra/tegra_asoc_machine.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/tegra/tegra_asoc_machine.c b/sound/soc/tegra/tegra_asoc_machine.c
> index 397f326..cba55ca 100644
> --- a/sound/soc/tegra/tegra_asoc_machine.c
> +++ b/sound/soc/tegra/tegra_asoc_machine.c
> @@ -336,9 +336,12 @@ tegra_machine_parse_phandle(struct device *dev, const char *name)
>  	}
>  
>  	err = devm_add_action_or_reset(dev, tegra_machine_node_release, np);
> -	if (err)
> +	if (err) {
> +		of_node_put(np);
>  		return ERR_PTR(err);
> +	}
>  
> +	of_node_put(np);
>  	return np;
>  }
>  
> 

You haven't tried to check what this auto-generated patch does, haven't
you? I assume it's auto-generated because it's a nonsense.