linux-kernel - Re: [PATCH -next v5] media: staging: atomisp: use list_splice_init in atomisp_compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <045418a7-181b-d11f-4c6f-5bfcb6d65c22@huawei.com>
Date:   Thu, 17 Jun 2021 21:44:49 +0800
From:   "libaokun (A)" <libaokun1@...wei.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     <mchehab@...nel.org>, <sakari.ailus@...ux.intel.com>,
        <gregkh@...uxfoundation.org>, <kaixuxia@...cent.com>,
        <gustavoars@...nel.org>, <linux-media@...r.kernel.org>,
        <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>,
        <yangjihong1@...wei.com>, <yukuai3@...wei.com>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next v5] media: staging: atomisp: use list_splice_init in
 atomisp_compat_css20.c

Thank you for your advice.

I'm about to send a patch v6 with the changes suggested by you.

Best Regards.


在 2021/6/17 21:26, Andy Shevchenko 写道:
> On Thu, Jun 17, 2021 at 08:53:57PM +0800, Baokun Li wrote:
>> Using list_splice_init() instead of entire while-loops
>> in atomisp_compat_css20.c.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Baokun Li <libaokun1@...wei.com>
>> ---
>> V1->V2:
>> 	CC mailist
>> V2->V3:
>>          Using list_move_tail() -> Using list_splice_init()
>> V3->V4:
>>          Remove redundant 'asd->'
>> V4->V5:
>>          Add the version information for 'V3->V4:'
> What about
>
> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2107:31: warning: unused variable 'md_buf' [-Wunused-variable]
> 2107 |  struct atomisp_metadata_buf *md_buf;
> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2106:26: warning: unused variable 'dis_buf' [-Wunused-variable]
> 2106 |  struct atomisp_dis_buf *dis_buf;
> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2105:26: warning: unused variable 's3a_buf' [-Wunused-variable]
> 2105 |  struct atomisp_s3a_buf *s3a_buf;
>
> ?
>