linux-kernel - Re: [PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6340eca-dcf6-770a-1296-8143df42d506@huawei.com>
Date:   Thu, 17 Jun 2021 22:06:15 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
        <linux-media@...r.kernel.org>, <mchehab@...nel.org>,
        <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH -next resend] media: staging: media: atomisp: pci: fix
 error return code in atomisp_pci_probe()


On 2021/6/17 21:58, Dan Carpenter wrote:
> Looks good.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> But next time please use v2 in the subject instead of "resend".  "resend"
> means that the process broke down somehow and we ignored your first
> patch.
>
> On Thu, Jun 17, 2021 at 09:55:00PM +0800, Yang Yingliang wrote:
>> If init_atomisp_wdts() fails, atomisp_pci_probe() need return
>> error code.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
>> ---
> Put a note here under the --- cut off line to say what happened since
> the last version.
>
> v2: style change
OK

Thanks,
Yang
>
>
>>   drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
> regards,
> dan carpenter
>
> .