linux-kernel - Re: [PATCH 2/2] watchdog: iTCO_wdt: use dev_err() instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210617020221.GB3214397@roeck-us.net>
Date:   Wed, 16 Jun 2021 19:02:21 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, wim@...ux-watchdog.org,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 2/2] watchdog: iTCO_wdt: use dev_err() instead of pr_err()

On Wed, Jun 16, 2021 at 08:17:08PM +0200, Enrico Weigelt, metux IT consult wrote:
> Use dev_err() instead of pr_err(), so device name is also shown in the log.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/iTCO_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 6ba2b2f60737..35ff8d3fd9fc 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -479,13 +479,13 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
>  		if (!devm_request_region(dev, p->smi_res->start,
>  					 resource_size(p->smi_res),
>  					 pdev->name)) {
> -			pr_err("I/O address 0x%04llx already in use, device disabled\n",
> +			dev_err(dev, "I/O address 0x%04llx already in use, device disabled\n",
>  			       (u64)SMI_EN(p));
>  			return -EBUSY;
>  		}
>  	} else if (iTCO_vendorsupport ||
>  		   turn_SMI_watchdog_clear_off >= p->iTCO_version) {
> -		pr_err("SMI I/O resource is missing\n");
> +		dev_err(dev, "SMI I/O resource is missing\n");
>  		return -ENODEV;
>  	}
>  
> -- 
> 2.20.1
>