linux-kernel - Re: [PATCH] isofs: remove redundant continue statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210617151216.GH32587@quack2.suse.cz>
Date:   Thu, 17 Jun 2021 17:12:16 +0200
From:   Jan Kara <jack@...e.cz>
To:     Colin King <colin.king@...onical.com>
Cc:     Pan Bian <bianpan2016@....com>, Jan Kara <jack@...e.cz>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] isofs: remove redundant continue statement

On Thu 17-06-21 13:08:37, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The continue statement in the while-loop has no effect,
> remove it.
> 
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks! I've added the patch to my tree.

								Honza

> ---
>  fs/isofs/dir.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c
> index b9e6a7ec78be..eb2f8273e6f1 100644
> --- a/fs/isofs/dir.c
> +++ b/fs/isofs/dir.c
> @@ -235,8 +235,6 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,
>  				break;
>  		}
>  		ctx->pos += de_len;
> -
> -		continue;
>  	}
>  	if (bh)
>  		brelse(bh);
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR