linux-kernel - Re: [PATCH v1 1/7] ACPI: sysfs: Make sparse happy about address space in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0g1R6Mtr9FECtes6nzXWLVtnRvGTFvi_Q_a8=fcJOhfUA@mail.gmail.com>
Date:   Thu, 17 Jun 2021 17:46:29 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1 1/7] ACPI: sysfs: Make sparse happy about address space
 in use

On Wed, Jun 16, 2021 at 7:03 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Sparse is not happy about address space in use in acpi_data_show():
>
> drivers/acpi/sysfs.c:428:14: warning: incorrect type in assignment (different address spaces)
> drivers/acpi/sysfs.c:428:14:    expected void [noderef] __iomem *base
> drivers/acpi/sysfs.c:428:14:    got void *
> drivers/acpi/sysfs.c:431:59: warning: incorrect type in argument 4 (different address spaces)
> drivers/acpi/sysfs.c:431:59:    expected void const *from
> drivers/acpi/sysfs.c:431:59:    got void [noderef] __iomem *base
> drivers/acpi/sysfs.c:433:30: warning: incorrect type in argument 1 (different address spaces)
> drivers/acpi/sysfs.c:433:30:    expected void *logical_address
> drivers/acpi/sysfs.c:433:30:    got void [noderef] __iomem *base
>
> Indeed, acpi_os_map_memory() returns a void pointer with dropped specific
> address space. Hence, we don't need to carry out __iomem in acpi_data_show().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/acpi/sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> index 88629d26bd48..767aa65e4bdd 100644
> --- a/drivers/acpi/sysfs.c
> +++ b/drivers/acpi/sysfs.c
> @@ -419,7 +419,7 @@ static ssize_t acpi_data_show(struct file *filp, struct kobject *kobj,
>                               loff_t offset, size_t count)
>  {
>         struct acpi_data_attr *data_attr;
> -       void __iomem *base;
> +       void *base;
>         ssize_t rc;
>
>         data_attr = container_of(bin_attr, struct acpi_data_attr, attr);
> --

Applied as 5.14 material along with patches [2-4,7/7] from this series.

Patches [5-6/7] did not apply for me on top of my acpi-sysfs branch
(that is included into my linux-next branch), so I have not applied
them.

Thanks!