linux-kernel - Re: [PATCH net-next v2] drivers: net: netdevsim: fix devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Jun 2021 20:03:07 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Oleksandr Mazur <oleksandr.mazur@...ision.eu>
Cc:     jiri@...dia.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vadym Kochan <vadym.kochan@...ision.eu>
Subject: Re: [PATCH net-next v2] drivers: net: netdevsim: fix devlink_trap
 selftests failing

On Thu, Jun 17, 2021 at 02:36:32PM +0300, Oleksandr Mazur wrote:
> devlink_trap tests for the netdevsim fail due to misspelled
> debugfs file name. Change this name, as well as name of callback
> function, to match the naming as in the devlink itself - 'trap_drop_counter'.
> 
> Test-results:
> selftests: drivers/net/netdevsim: devlink_trap.sh
> TEST: Initialization                                                [ OK ]
> TEST: Trap action                                                   [ OK ]
> TEST: Trap metadata                                                 [ OK ]
> TEST: Non-existing trap                                             [ OK ]
> TEST: Non-existing trap action                                      [ OK ]
> TEST: Trap statistics                                               [ OK ]
> TEST: Trap group action                                             [ OK ]
> TEST: Non-existing trap group                                       [ OK ]
> TEST: Trap group statistics                                         [ OK ]
> TEST: Trap policer                                                  [ OK ]
> TEST: Trap policer binding                                          [ OK ]
> TEST: Port delete                                                   [ OK ]
> TEST: Device delete                                                 [ OK ]
> 
> Fixes: a7b3527a43fe ("drivers: net: netdevsim: add devlink trap_drop_counter_get implementation")
> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@...ision.eu>

Reviewed-by: Ido Schimmel <idosch@...dia.com>
Tested-by: Ido Schimmel <idosch@...dia.com>