linux-kernel - Re: [PATCH] serial: amba-pl011: add RS485 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c0ac56d-58da-5e8a-b6be-44bafb183443@gmx.de>
Date:   Thu, 17 Jun 2021 19:44:21 +0200
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Jiri Slaby <jirislaby@...nel.org>, gregkh@...uxfoundation.org
Cc:     linux@...linux.org.uk, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: amba-pl011: add RS485 support


Hi,

On 16.06.21 at 08:18, Jiri Slaby wrote:
        mdelay(port->rs485.delay_rts_before_send);
>
> This is up to 1 second delay with interrupts disabled. Definitely not nice. 8250 clamps this to 100 ms at least, why did you choose 1000 ms?
>

AFAICS the 8250 driver does not clamp values read from the device tree property "rs485-rts-delay"
(set by uart_get_rs485_mode()). Is this on purpose?

Regards,
Lino