linux-kernel - Re: [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Jun 2021 01:56:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Wesley Cheng <wcheng@...eaurora.org>, balbi@...nel.org,
        gregkh@...uxfoundation.org, robh+dt@...nel.org, agross@...nel.org,
        bjorn.andersson@...aro.org, frowand.list@...il.com
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting
 requirements

Hi Wesley,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on robh/for-next v5.13-rc6 next-20210617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-a011-20210617 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/94892083cf17e46a29d4ef33a044af04854162e6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037
        git checkout 94892083cf17e46a29d4ef33a044af04854162e6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/dwc3/gadget.c:671:18: warning: variable 'dep' set but not used [-Wunused-but-set-variable]
           struct dwc3_ep *dep;
                           ^
   1 warning generated.
--
   drivers/usb/dwc3/gadget.c:648: warning: Function parameter or member 'mult' not described in 'dwc3_gadget_calc_tx_fifo_size'
   drivers/usb/dwc3/gadget.c:648: warning: Excess function parameter 'nfifos' description in 'dwc3_gadget_calc_tx_fifo_size'
>> drivers/usb/dwc3/gadget.c:670: warning: expecting prototype for dwc3_gadget_clear_tx_fifo_size(). Prototype was for dwc3_gadget_clear_tx_fifos() instead


vim +/dep +671 drivers/usb/dwc3/gadget.c

   661	
   662	/**
   663	 * dwc3_gadget_clear_tx_fifo_size - Clears txfifo allocation
   664	 * @dwc: pointer to the DWC3 context
   665	 *
   666	 * Iterates through all the endpoint registers and clears the previous txfifo
   667	 * allocations.
   668	 */
   669	void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc)
 > 670	{
 > 671		struct dwc3_ep *dep;
   672		int fifo_depth;
   673		int size;
   674		int num;
   675	
   676		if (!dwc->do_fifo_resize)
   677			return;
   678	
   679		/* Read ep0IN related TXFIFO size */
   680		dep = dwc->eps[1];
   681		size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0));
   682		if (DWC3_IP_IS(DWC3))
   683			fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size);
   684		else
   685			fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size);
   686	
   687		dwc->last_fifo_depth = fifo_depth;
   688		/* Clear existing TXFIFO for all IN eps except ep0 */
   689		for (num = 3; num < min_t(int, dwc->num_eps, DWC3_ENDPOINTS_NUM);
   690		     num += 2) {
   691			dep = dwc->eps[num];
   692			/* Don't change TXFRAMNUM on usb31 version */
   693			size = DWC3_IP_IS(DWC3) ? 0 :
   694				dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) &
   695					   DWC31_GTXFIFOSIZ_TXFRAMNUM;
   696	
   697			dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size);
   698		}
   699		dwc->num_ep_resized = 0;
   700	}
   701	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34458 bytes)