linux-kernel - Re: [PATCH] slab: Use %s instead of function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c51952f7-a355-b038-4377-f6673c413d1f@google.com>
Date:   Fri, 18 Jun 2021 12:32:53 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
cc:     gumingtao <gumingtao1225@...il.com>, cl@...ux.com,
        penberg@...nel.org, iamjoonsoo.kim@....com,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linux-MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        gumingtao <gumingtao@...omi.com>
Subject: Re: [PATCH] slab: Use %s instead of function name

On Fri, 18 Jun 2021, Lukas Bulwahn wrote:

> > It is better to replace the function name with %s.
> >
> > Signed-off-by: gumingtao <gumingtao@...omi.com>
> > ---
> >  mm/slab_common.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/slab_common.c b/mm/slab_common.c
> > index a4a5714..36127dc 100644
> > --- a/mm/slab_common.c
> > +++ b/mm/slab_common.c
> > @@ -381,8 +381,8 @@ kmem_cache_create_usercopy(const char *name,
> >                         panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n",
> 
> I am just wondering:
> 
> Can you also make that refactoring change for the panic() call as well?
> 
> How about checking the whole file for such patterns and doing that
> change for all occurrences?
> 

Yeah, that would be ideal if gumingtao is willing to do it.  These are 
some instances where the function name actually mismatches.  gumingtao, 
would you be willing to do this?