linux-kernel - Re: [PATCH] mm/slub: Add taint after the errors are printed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <413080c2-bfd7-f386-709c-43718242ae87@google.com>
Date:   Fri, 18 Jun 2021 12:38:01 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Georgi Djakov <quic_c_gdjako@...cinc.com>
cc:     vbabka@...e.cz, akpm@...ux-foundation.org, iamjoonsoo.kim@....com,
        penberg@...nel.org, cl@...ux.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, djakov@...nel.org
Subject: Re: [PATCH] mm/slub: Add taint after the errors are printed

On Wed, 16 Jun 2021, Georgi Djakov wrote:

> When running the kernel with panic_on_taint, the usual slub debug error
> messages are not being printed when object corruption happens. That's
> because we panic in add_taint(), which is called before printing the
> additional information. This is a bit unfortunate as the error messages
> are actually very useful, especially before a panic. Let's fix this by
> moving add_taint() after the errors are printed on the console.
> 
> Signed-off-by: Georgi Djakov <quic_c_gdjako@...cinc.com>

Acked-by: David Rientjes <rientjes@...gle.com>