linux-kernel - Re: [patch V3 61/66] x86/fpu/signal: Sanitize the xstate check on sigframe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h7huensk.ffs@nanos.tec.linutronix.de>
Date:   Sat, 19 Jun 2021 01:49:31 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andrew Cooper <andrew.cooper3@...rix.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Borislav Petkov <bp@...e.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Andrew Cooper <andrew.cooper3@...rix.com>
Subject: Re: [patch V3 61/66] x86/fpu/signal: Sanitize the xstate check on sigframe

Andrew,

On Fri, Jun 18 2021 at 22:02, Andrew Cooper wrote:
> On 18/06/2021 15:19, Thomas Gleixner wrote:
>> -static struct _fpx_sw_bytes fx_sw_reserved, fx_sw_reserved_ia32;
>> +static struct _fpx_sw_bytes fx_sw_reserved, fx_sw_reserved_ia32 __ro_after_init;
>
> You probably want a second __ro_after_init here.

Ooops.

Thanks for spotting it!

       tglx