| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b9beccabc8ba88e889d6f6317afecd05@codeaurora.org>
Date: Fri, 18 Jun 2021 11:22:32 +0530
From: Prasad Malisetty <pmaliset@...eaurora.org>
To: Bjorn Andersson <bjorn.andersson@...aro.org>
Cc: agross@...nel.org, bhelgaas@...gle.com, robh+dt@...nel.org,
swboyd@...omium.org, lorenzo.pieralisi@....com,
svarbanov@...sol.com, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, mgautam@...eaurora.org,
dianders@...omium.org, mka@...omium.org, sanm@...eaurora.org
Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sc7280: Add PCIe and PHY related
nodes
On 2021-06-06 07:56, Bjorn Andersson wrote:
> On Sat 05 Jun 09:40 CDT 2021, Prasad Malisetty wrote:
>
>> Add PCIe controller and PHY nodes for sc7280 SOC.
>>
>> Signed-off-by: Prasad Malisetty <pmaliset@...eaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 138
>> +++++++++++++++++++++++++++++++++++
>> 1 file changed, 138 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 0b6f119..9e8414d 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -15,6 +15,7 @@
>> #include <dt-bindings/reset/qcom,sdm845-pdc.h>
>> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> #include <dt-bindings/thermal/thermal.h>
>> +#include <dt-bindings/gpio/gpio.h>
>>
>> / {
>> interrupt-parent = <&intc>;
>> @@ -484,6 +485,117 @@
>> #power-domain-cells = <1>;
>> };
>>
>> + pcie1: pci@...8000 {
>
> Does this name imply that you have a pcie0 as well? Please introduce it
> while you're at it.
>
>> We are not using pcie0 for HLOS.
>> + compatible = "qcom,pcie-sc7280", "qcom,pcie-sm8250",
>> "snps,dw-pcie";
>> + reg = <0 0x01c08000 0 0x3000>,
>> + <0 0x40000000 0 0xf1d>,
>> + <0 0x40000f20 0 0xa8>,
>> + <0 0x40001000 0 0x1000>,
>> + <0 0x40100000 0 0x100000>;
>> +
>> + reg-names = "parf", "dbi", "elbi", "atu", "config";
>> + device_type = "pci";
>> + linux,pci-domain = <1>;
>> + bus-range = <0x00 0xff>;
>> + num-lanes = <2>;
>> +
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> +
>> + ranges = <0x01000000 0x0 0x40200000 0x0 0x40200000 0x0 0x100000>,
>> + <0x02000000 0x0 0x40300000 0x0 0x40300000 0x0 0x1fd00000>;
>> +
>> + interrupts = <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "msi";
>> + #interrupt-cells = <1>;
>> + interrupt-map-mask = <0 0 0 0x7>;
>> + interrupt-map = <0 0 0 1 &intc 0 434 IRQ_TYPE_LEVEL_HIGH>, /*
>> int_a */
>> + <0 0 0 2 &intc 0 435 IRQ_TYPE_LEVEL_HIGH>, /* int_b */
>> + <0 0 0 3 &intc 0 438 IRQ_TYPE_LEVEL_HIGH>, /* int_c */
>> + <0 0 0 4 &intc 0 439 IRQ_TYPE_LEVEL_HIGH>; /* int_d */
>> +
>> + clocks = <&gcc GCC_PCIE_1_PIPE_CLK>,
>> + <&gcc GCC_PCIE_1_PIPE_CLK_SRC>,
>> + <&pcie1_lane 0>,
>> + <&rpmhcc RPMH_CXO_CLK>,
>> + <&gcc GCC_PCIE_1_AUX_CLK>,
>> + <&gcc GCC_PCIE_1_CFG_AHB_CLK>,
>> + <&gcc GCC_PCIE_1_MSTR_AXI_CLK>,
>> + <&gcc GCC_PCIE_1_SLV_AXI_CLK>,
>> + <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>,
>> + <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>,
>> + <&gcc GCC_DDRSS_PCIE_SF_CLK>;
>> +
>> + clock-names = "pipe",
>> + "pipe_src",
>> + "pipe_ext",
>> + "ref",
>> + "aux",
>> + "cfg",
>> + "bus_master",
>> + "bus_slave",
>> + "slave_q2a",
>> + "tbu",
>> + "ddrss_sf_tbu";
>> +
>> + assigned-clocks = <&gcc GCC_PCIE_1_AUX_CLK>;
>> + assigned-clock-rates = <19200000>;
>> +
>> + resets = <&gcc GCC_PCIE_1_BCR>;
>> + reset-names = "pci";
>> +
>> + power-domains = <&gcc GCC_PCIE_1_GDSC>;
>> +
>> + phys = <&pcie1_lane>;
>> + phy-names = "pciephy";
>> +
>> + perst-gpio = <&tlmm 2 GPIO_ACTIVE_LOW>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pcie1_default_state>;
>> +
>> + iommus = <&apps_smmu 0x1c80 0x1>;
>> +
>> + iommu-map = <0x0 &apps_smmu 0x1c80 0x1>,
>> + <0x100 &apps_smmu 0x1c81 0x1>;
>> +
>> + status = "disabled";
>> + };
>> +
>> + pcie1_phy: phy@...e000 {
>> + compatible = "qcom,sm8250-qmp-gen3x2-pcie-phy";
>
> No, you don't have a sm8250-qmp-gen3x2-pcie-phy in your sc7280.
>
>> Both are having same PHY sequence.
>> + status = "disabled";
>> + reg = <0 0x01c0e000 0 0x1c0>;
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> + clocks = <&gcc GCC_PCIE_1_AUX_CLK>,
>> + <&gcc GCC_PCIE_1_CFG_AHB_CLK>,
>> + <&gcc GCC_PCIE_CLKREF_EN>,
>> + <&gcc GCC_PCIE1_PHY_RCHNG_CLK>;
>> + clock-names = "aux", "cfg_ahb", "ref", "refgen";
>> +
>> + resets = <&gcc GCC_PCIE_1_PHY_BCR>;
>> + reset-names = "phy";
>> +
>> + assigned-clocks = <&gcc GCC_PCIE1_PHY_RCHNG_CLK>;
>> + assigned-clock-rates = <100000000>;
>> +
>> + pcie1_lane: lanes@...e200 {
>> + reg = <0 0x01c0e200 0 0x170>,
>> + <0 0x01c0e400 0 0x200>,
>> + <0 0x01c0ea00 0 0x1f0>,
>> + <0 0x01c0e600 0 0x170>,
>> + <0 0x01c0e800 0 0x200>,
>> + <0 0x01c0ee00 0 0xf4>;
>> + clocks = <&rpmhcc RPMH_CXO_CLK>;
>> + clock-names = "pipe0";
>> +
>> + #phy-cells = <0>;
>> + #clock-cells = <1>;
>> + clock-output-names = "pcie_1_pipe_clk";
>> + };
>> + };
>> +
>> stm@...2000 {
>> compatible = "arm,coresight-stm", "arm,primecell";
>> reg = <0 0x06002000 0 0x1000>,
>> @@ -1102,6 +1214,32 @@
>> pins = "gpio46", "gpio47";
>> function = "qup13";
>> };
>> +
>> + pcie1_default_state: pcie1-default {
>
> Per the binding the name has to end with "-pins", although I would like
> us to change that to "-state". Either way, this is not correct.
>
>> + clkreq {
>> + pins = "gpio79";
>> + function = "pcie1_clkreqn";
>> + };
>> +
>> + reset-n {
>> + pins = "gpio2";
>> + function = "gpio";
>> +
>> + drive-strength = <16>;
>> + output-low;
>> + bias-disable;
>> + };
>> +
>> + wake-n {
>> + pins = "gpio3";
>> + function = "gpio";
>> + };
>> +
>> + nvme-n {
>
> This doesn't look like a standard PCIe pin, is it perhaps the enable
> pin
> for the regulator powering your NVME, or something along those lines?
>
> If so you should describe it as a fixed-regulator...and either way I
> suspect it should be moved to the device specific file.
>
> Regards,
> Bjorn
>
> Agree, will move into board specific file.
>> + pins = "gpio19";
>> + function = "gpio";
>> + };
>> + };
>> };
>>
>> apps_smmu: iommu@...00000 {
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
Powered by blists - more mailing lists