linux-kernel - Re: [RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3493815.vrqWZg68TM@diego>
Date:   Fri, 18 Jun 2021 09:01:59 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     cl <cl@...k-chips.com>,
        "jay.xu@...k-chips.com" <jay.xu@...k-chips.com>
Cc:     robh+dt <robh+dt@...nel.org>, jagan <jagan@...rulasolutions.com>,
        wens <wens@...e.org>, uwe <uwe@...ine-koenig.org>,
        mail <mail@...id-bauer.net>, Johan Jonker <jbx6244@...il.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        jensenhuang <jensenhuang@...endlyarm.com>,
        michael <michael@...rulasolutions.com>,
        cnsztl <cnsztl@...il.com>,
        devicetree <devicetree@...r.kernel.org>,
        "ulf. hansson" <ulf.hansson@...aro.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        gregkh <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        林涛(底层平台) <shawn.lin@...k-chips.com>,
        吴达超 <david.wu@...k-chips.com>,
        zhangqing <zhangqing@...k-chips.com>,
        Tao Huang <huangtao@...k-chips.com>, cl <cl@...k-chips.com>,
        wim <wim@...ux-watchdog.org>, linux <linux@...ck-us.net>,
        jamie <jamie@...ieiles.com>,
        linux-watchdog <linux-watchdog@...r.kernel.org>,
        maz <maz@...nel.org>
Subject: Re: [RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank

Hi Jay,

Am Freitag, 18. Juni 2021, 08:41:45 CEST schrieb jay.xu@...k-chips.com:
> Hi Heiko
> 
> --------------
> jay.xu@...k-chips.com
> >Hi,
> >
> >Am Donnerstag, 13. Mai 2021, 08:46:06 CEST schrieb cl@...k-chips.com:
> >> From: Liang Chen <cl@...k-chips.com>
> >>
> >> The clock property need 2 items on some rockchip chips.
> >>
> >> Signed-off-by: Liang Chen <cl@...k-chips.com>
> >
> >this patch should definitly move over to Jianquns gpio driver series,
> >as it introduces the usage of these new clocks.
> >
> >Also while the single-clock variant definitly doesn't need it,
> >I think we may want clock-names "apb_pclk", "debounce-ref" for the
> >2-clock variants?
> > 
> Okay, I think it's very good idea, 
> but is it possible to post the reg-name patch after these dts serial and gpio serial patches ?

You're already creating a new binding when changing the max-items.
So when we change that again later, in theory you'd need to support both
cases (with and without clock-names)

So I'd really prefer to get the binding right the first time and
identifying multiple clocks by clock-names instead of an implicit ordering
is way better in the long run as well.

Heiko




> 
> >
> >Heiko
> >
> >> ---
> >>  Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> index d993e00..0d62c28 100644
> >> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> @@ -22,7 +22,10 @@ properties:
> >>      maxItems: 1
> >> 
> >>    clocks:
> >> -    maxItems: 1
> >> +    minItems: 1
> >> +    items:
> >> +      - description: APB interface clock source
> >> +      - description: GPIO debounce reference clock source
> >> 
> >>    gpio-controller: true
> >> 
> >>
> >
> >
> >
> >
> >
> >
> >
>