linux-kernel - Re: [PATCH v1] can: j1939: j1939_sk_init(): set SOCK_RCU_FREE to call sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210618071532.kr7o2rnx6ia4t6n6@pengutronix.de>
Date:   Fri, 18 Jun 2021 09:15:32 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        Robin van der Gracht <robin@...tonic.nl>,
        Thadeu Lima de Souza Cascardo <cascardo@...onical.com>,
        syzbot+bdf710cfc41c186fdff3@...kaller.appspotmail.com,
        kernel@...gutronix.de, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] can: j1939: j1939_sk_init(): set SOCK_RCU_FREE to
 call sk_destruct() after RCU is done

On 17.06.2021 15:06:23, Oleksij Rempel wrote:
> Set SOCK_RCU_FREE to let RCU to call sk_destruct() on completion.
> Without this patch, we will run in to j1939_can_recv() after priv was
> freed by j1939_sk_release()->j1939_sk_sock_destruct()
> 
> Reported-by: Thadeu Lima de Souza Cascardo <cascardo@...onical.com>
> Reported-by: syzbot+bdf710cfc41c186fdff3@...kaller.appspotmail.com
> Fixes: 25fe97cb7620 ("can: j1939: move j1939_priv_put() into sk_destruct callback")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Applied to linux-can/testing.

Thanks,
Marc
-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)