linux-kernel - Re: [PATCH 1/1] quota: remove unnecessary oom message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e56de5db-9b76-6d24-68c9-0acb3776c9e8@huawei.com>
Date:   Fri, 18 Jun 2021 09:20:34 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Jan Kara <jack@...e.cz>
CC:     Jan Kara <jack@...e.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] quota: remove unnecessary oom message



On 2021/6/17 23:01, Jan Kara wrote:
> On Thu 17-06-21 17:16:27, Zhen Lei wrote:
>> Fixes scripts/checkpatch.pl warning:
>> WARNING: Possible unnecessary 'out of memory' message
>>
>> Remove it can help us save a bit of memory.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> 
> I agree the message is pointless. But when doing this, I guess we can just
> get rid of getdqbuf() altogether and instead call kmalloc() directly in all
> the places.

OK, I will get rid of it in v2.

> 
> 								Honza
> 
>> diff --git a/fs/quota/quota_tree.c b/fs/quota/quota_tree.c
>> index c5562c871c8b..b097d02bad94 100644
>> --- a/fs/quota/quota_tree.c
>> +++ b/fs/quota/quota_tree.c
>> @@ -49,11 +49,7 @@ static int qtree_dqstr_in_blk(struct qtree_mem_dqinfo *info)
>>  
>>  static char *getdqbuf(size_t size)
>>  {
>> -	char *buf = kmalloc(size, GFP_NOFS);
>> -	if (!buf)
>> -		printk(KERN_WARNING
>> -		       "VFS: Not enough memory for quota buffers.\n");
>> -	return buf;
>> +	return kmalloc(size, GFP_NOFS);
>>  }
>>  
>>  static ssize_t read_blk(struct qtree_mem_dqinfo *info, uint blk, char *buf)
>> -- 
>> 2.25.1
>>
>>