linux-kernel - Re: [PATCH -next] crypto: sl3516 - Fix build warning without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00d33044-8101-bc41-ac02-90517c13f19a@huawei.com>
Date:   Fri, 18 Jun 2021 15:57:13 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     LABBE Corentin <clabbe@...libre.com>
CC:     <ulli.kroll@...glemail.com>, <linus.walleij@...aro.org>,
        <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] crypto: sl3516 - Fix build warning without
 CONFIG_PM

On 2021/6/17 21:00, LABBE Corentin wrote:
> Le Thu, Jun 17, 2021 at 11:51:29AM +0800, YueHaibing a écrit :
>> drivers/crypto/gemini/sl3516-ce-core.c:345:12:
>>  warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function]
>>  static int sl3516_ce_pm_resume(struct device *dev)
>>             ^~~~~~~~~~~~~~~~~~~
>>
>> Use #ifdef macro to guard this.
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/crypto/gemini/sl3516-ce-core.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
> 
> Hello
> 
> Thanks for the report, but I am sorry and need to NAK this patch.
> 
> The driver needs PM, without it, clock and resets are never set.
> The correct fix is to add "depends on PM".

Ok, v2 on the way, thanks.

> 
> Regards
> .
>