linux-kernel - Re: [PATCH -next] mtd: rawnand: arasan: Fix missing clk_disable_unprepare() on error in anfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be3b786d-dc6e-90b5-9bc6-05d078b21c40@huawei.com>
Date:   Fri, 18 Jun 2021 20:35:13 +0800
From:   Samuel Zou <zou_wei@...wei.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
CC:     <nagasure@...inx.com>, <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mtd: rawnand: arasan: Fix missing
 clk_disable_unprepare() on error in anfc_probe()


Hi Miquel,

Thanks for your review, and it's OK include the goto change.

On 2021/6/18 15:27, Miquel Raynal wrote:
> Hi Zou,
> 
> Zou Wei <zou_wei@...wei.com> wrote on Wed, 16 Jun 2021 12:06:44 +0800:
> 
>> Fix the missing clk_disable_unprepare() before return
>> from anfc_probe() in the error handling case.
>>
>> Fixes: 61622f6791a1 ("mtd: rawnand: arasan: Use the right DMA mask")
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> 
> Thanks for the patch, 61622f6791a1 being problematic because of the
> mask not being correctly declared I prefer to fix this patch inline and
> if you don't mind I'll include the goto change as well.
> 
>> ---
>>   drivers/mtd/nand/raw/arasan-nand-controller.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c
>> index 8317d97..9cbcc69 100644
>> --- a/drivers/mtd/nand/raw/arasan-nand-controller.c
>> +++ b/drivers/mtd/nand/raw/arasan-nand-controller.c
>> @@ -1452,7 +1452,7 @@ static int anfc_probe(struct platform_device *pdev)
>>   
>>   	ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
>>   	if (ret)
>> -		return ret;
>> +		goto disable_bus_clk;
>>   
>>   	ret = anfc_parse_cs(nfc);
>>   	if (ret)
> 
> Thanks,
> Miquèl
> .
>