linux-kernel - Re: [PATCH 1/3] fs/fuse: Remove unneeded kaddr parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210618124915.GA1234055@redhat.com>
Date:   Fri, 18 Jun 2021 08:49:15 -0400
From:   Vivek Goyal <vgoyal@...hat.com>
To:     Miklos Szeredi <miklos@...redi.hu>
Cc:     Ira Weiny <ira.weiny@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        linux-kernel@...r.kernel.org,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/3] fs/fuse: Remove unneeded kaddr parameter

On Fri, Jun 18, 2021 at 09:01:39AM +0200, Miklos Szeredi wrote:
> On Fri, 11 Jun 2021 at 19:23, Ira Weiny <ira.weiny@...el.com> wrote:
> >
> > On Tue, May 25, 2021 at 10:24:26AM -0700, 'Ira Weiny' wrote:
> > > From: Ira Weiny <ira.weiny@...el.com>
> > >
> > > fuse_dax_mem_range_init() does not need the address or the pfn of the
> > > memory requested in dax_direct_access().  It is only calling direct
> > > access to get the number of pages.
> >
> > In looking for feedback on this small series I realize that I failed to email
> > Miklos for the fs/fuse patch.
> >
> > I'm adding Miklos to the To line...
> 
> LGTM, but this is Vivek's code, so adding Cc.
> 

Looks good to me as well. We are not using pfn and kaddr in
fuse_dax_mem_range_init().

Reviewed-by: Vivek Goyal <vgoyal@...hat.com>

Thanks
Vivek

> Thanks,
> Miklos
> 
> 
> >
> > For the rest of the series is there any feedback?
> >
> > Ira
> >
> > >
> > > Remove the unused variables and stop requesting the kaddr and pfn from
> > > dax_direct_access().
> > >
> > > Reviewed-by: Dan Williams <dan.j.williams@...el.com>
> > > Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> > > ---
> > >  fs/fuse/dax.c | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c
> > > index ff99ab2a3c43..34f8a5635c7f 100644
> > > --- a/fs/fuse/dax.c
> > > +++ b/fs/fuse/dax.c
> > > @@ -1234,8 +1234,6 @@ void fuse_dax_conn_free(struct fuse_conn *fc)
> > >  static int fuse_dax_mem_range_init(struct fuse_conn_dax *fcd)
> > >  {
> > >       long nr_pages, nr_ranges;
> > > -     void *kaddr;
> > > -     pfn_t pfn;
> > >       struct fuse_dax_mapping *range;
> > >       int ret, id;
> > >       size_t dax_size = -1;
> > > @@ -1247,8 +1245,8 @@ static int fuse_dax_mem_range_init(struct fuse_conn_dax *fcd)
> > >       INIT_DELAYED_WORK(&fcd->free_work, fuse_dax_free_mem_worker);
> > >
> > >       id = dax_read_lock();
> > > -     nr_pages = dax_direct_access(fcd->dev, 0, PHYS_PFN(dax_size), &kaddr,
> > > -                                  &pfn);
> > > +     nr_pages = dax_direct_access(fcd->dev, 0, PHYS_PFN(dax_size), NULL,
> > > +                                  NULL);
> > >       dax_read_unlock(id);
> > >       if (nr_pages < 0) {
> > >               pr_debug("dax_direct_access() returned %ld\n", nr_pages);
> > > --
> > > 2.28.0.rc0.12.gb6a658bd00c9
> > >
>