linux-kernel - Re: [PATCH] locking/lockdep: Correct the description error for check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEVVKH-h4fK0WobzfKUBs9d2t+XPmUQQCYJQmacPPVymFrntrA@mail.gmail.com>
Date:   Fri, 18 Jun 2021 21:16:15 +0800
From:   Xiongwei Song <sxwjean@...il.com>
To:     Xiongwei Song <sxwjean@...com>
Cc:     peterz@...radead.org, mingo@...hat.com, will@...nel.org,
        longman@...hat.com, Boqun Feng <boqun.feng@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] locking/lockdep: Correct the description error for check_redundant()

On Fri, Jun 18, 2021 at 9:02 PM Xiongwei Song <sxwjean@...com> wrote:
>
> From: Xiongwei Song <sxwjean@...il.com>
>
> If there is no matched result, check_redundant() will return BFS_RNOMATCH.
>
> Signed-off-by: Xiongwei Song <sxwjean@...il.com>
> Reviewed-by: Boqun Feng <boqun.feng@...il.com>
> ---
>  kernel/locking/lockdep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index cfe0f4374594..1f126ca7fbd7 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
>   * <target> or not. If it can, <src> -> <target> dependency is already
>   * in the graph.
>   *
> - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
> + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
>   * any error appears in the bfs search.
>   */
>  static noinline enum bfs_result

Sorry I forgot to add version info, this is v2.
Regarding v1 please see https://lkml.org/lkml/2021/6/17/1156.

Regards,
Xiongwei

> --
> 2.30.2
>