linux-kernel - RE: [PATCH] pci-hyperv: Add check for hyperv_initialized in init_hv_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR21MB12953B17F1C0C9B4F95A6676CA0D9@MN2PR21MB1295.namprd21.prod.outlook.com>
Date:   Fri, 18 Jun 2021 13:26:06 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     Wei Liu <wei.liu@...nel.org>, Bjorn Helgaas <helgaas@...nel.org>
CC:     "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        KY Srinivasan <kys@...rosoft.com>,
        "olaf@...fle.de" <olaf@...fle.de>, vkuznets <vkuznets@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] pci-hyperv: Add check for hyperv_initialized in
 init_hv_pci_drv()



> -----Original Message-----
> From: Wei Liu <wei.liu@...nel.org>
> Sent: Friday, June 18, 2021 9:23 AM
> To: Bjorn Helgaas <helgaas@...nel.org>
> Cc: Wei Liu <wei.liu@...nel.org>; Haiyang Zhang <haiyangz@...rosoft.com>;
> bhelgaas@...gle.com; lorenzo.pieralisi@....com; linux-
> hyperv@...r.kernel.org; linux-pci@...r.kernel.org; KY Srinivasan
> <kys@...rosoft.com>; olaf@...fle.de; vkuznets <vkuznets@...hat.com>;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] pci-hyperv: Add check for hyperv_initialized in
> init_hv_pci_drv()
> 
> On Sat, Jun 05, 2021 at 10:40:21AM +0000, Wei Liu wrote:
> > On Fri, Jun 04, 2021 at 04:26:22PM -0500, Bjorn Helgaas wrote:
> > > On Wed, Jun 02, 2021 at 10:32:06AM +0000, Wei Liu wrote:
> > > > On Tue, May 25, 2021 at 04:17:33PM -0700, Haiyang Zhang wrote:
> > > > > Add check for hv_is_hyperv_initialized() at the top of
> > > > > init_hv_pci_drv(), so if the pci-hyperv driver is force-loaded
> > > > > on non Hyper-V platforms, the
> > > > > init_hv_pci_drv() will exit immediately, without any side
> > > > > effects, like assignments to hvpci_block_ops, etc.
> > > > >
> > > > > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > > > > Reported-and-tested-by: Mohammad Alqayeem
> > > > > <mohammad.alqyeem@...anix.com>
> > > >
> > > > Hello PCI subsystem maintainers, are you going to take this patch
> > > > or shall I?
> > >
> > > This was mistakenly assigned to me, so I reassigned it back to
> > > Lorenzo.
> > >
> > > If you *do* take this, please at least update it to follow the PCI
> > > commit log conventions, e.g.,
> > >
> > >   PCI: hv: Add check ...
> > >
> > > and wrap the text so it fits in 75 columns.
> >
> > Lorenzo already picked up two Hyper-V PCI patches from Long Li. I
> > think leaving this to him is better.
> >
> 
> This patch is still missing from pci/hv, so I've picked it up via hyperv-next
> (with the adjustments required by Bjorn).

Thank you!

- Haiyang