linux-kernel - Re: [PATCH] dmaengine: mediatek: Return the correct errno code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2eb509a4-73dd-b3db-41d3-e7a0043ce8c9@gmail.com>
Date:   Fri, 18 Jun 2021 15:53:02 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     angkery <angkery@....com>, sean.wang@...iatek.com, vkoul@...nel.org
Cc:     dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Junlin Yang <yangjunlin@...ong.com>
Subject: Re: [PATCH] dmaengine: mediatek: Return the correct errno code



On 17/06/2021 15:32, angkery wrote:
> From: Junlin Yang <yangjunlin@...ong.com>
> 
> When devm_kzalloc failed, should return ENOMEM rather than ENODEV.
> 
> Signed-off-by: Junlin Yang <yangjunlin@...ong.com>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>  drivers/dma/mediatek/mtk-uart-apdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
> index 375e7e6..a4cb30f 100644
> --- a/drivers/dma/mediatek/mtk-uart-apdma.c
> +++ b/drivers/dma/mediatek/mtk-uart-apdma.c
> @@ -529,7 +529,7 @@ static int mtk_uart_apdma_probe(struct platform_device *pdev)
>  	for (i = 0; i < mtkd->dma_requests; i++) {
>  		c = devm_kzalloc(mtkd->ddev.dev, sizeof(*c), GFP_KERNEL);
>  		if (!c) {
> -			rc = -ENODEV;
> +			rc = -ENOMEM;
>  			goto err_no_dma;
>  		}
>  
>