linux-kernel - Re: [PATCH v3 1/2] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5heeczw9kz.wl-tiwai@suse.de>
Date:   Fri, 18 Jun 2021 16:06:52 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Andy Chi <andy.chi@...onical.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8

On Fri, 18 Jun 2021 12:24:21 +0200,
Andy Chi wrote:
> 
> >From fdeab6f32dbdbfd83c9af6efc5a51f91021b6578 Mon Sep 17 00:00:00 2001
> From: Andy Chi <andy.chi@...onical.com>
> Date: Fri, 18 Jun 2021 16:17:48 +0800
> Subject: [PATCH v3 1/2] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook
>  450 G8

Still something wrong in your submission.  e.g. the patch included the
bogus "From" line, and repeated From:, Date: and Subject: headers.
But, more badly...

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ab5113cccffa..70bc5b11acfd 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -8336,6 +8336,7 @@ static const struct snd_pci_quirk
> alc269_fixup_tbl[] = {

... the patch itself is inapplicable, it contains line breaks.
(e.g. the above should be a single line).

Try to submit via git-send-email.  If it's difficult, just give via
attachments in the worst case.


thanks,

Takashi