linux-kernel - Re: [PATCH][next] opp: remove redundant continue statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210618033228.mork47zl3xydwb34@vireshk-i7>
Date:   Fri, 18 Jun 2021 09:02:28 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>, linux-pm@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] opp: remove redundant continue statement

On 17-06-21, 14:50, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The continue statement at the end of a for-loop has no effect,
> remove it.
> 
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/opp/of.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 9573facce53a..d298e38aaf7e 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -197,10 +197,8 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
>  		required_opp_tables[i] = _find_table_of_opp_np(required_np);
>  		of_node_put(required_np);
>  
> -		if (IS_ERR(required_opp_tables[i])) {
> +		if (IS_ERR(required_opp_tables[i]))
>  			lazy = true;
> -			continue;
> -		}
>  	}

I had to merge this with:

"opp: Allow required-opps to be used for non genpd use cases"

Thanks for the report anyway :)

-- 
viresh