linux-kernel - Re: [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1fbaad3-972b-53f5-817c-9b6ee14a02ce@gmail.com>
Date:   Sat, 19 Jun 2021 08:46:22 -0700
From:   James Smart <jsmart2021@...il.com>
To:     Colin King <colin.king@...onical.com>,
        James Smart <james.smart@...adcom.com>,
        Ram Vegesna <ram.vegesna@...adcom.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Hannes Reinecke <hare@...e.de>, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of
 a unsigned int

On 6/16/2021 10:04 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The comparison of the u32 variable rc to less than zero always
> false because it is unsigned. Fix this by making it an int.
> 
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/scsi/elx/libefc/efc_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Reviewed-by: James Smart <jsmart2021@...il.com>

-- james