[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <yq1wnqqy481.fsf@ca-mkp.ca.oracle.com>
Date: Fri, 18 Jun 2021 22:32:05 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Nathan Chancellor <nathan@...nel.org>
Cc: James Smart <james.smart@...adcom.com>,
Ram Vegesna <ram.vegesna@...adcom.com>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Nick Desaulniers <ndesaulniers@...gle.com>,
linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in
efct_hw_command_cancel()
Nathan,
> clang warns:
>
> drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
> 'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
> (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
> ~~~~~~^~~
>
> buf is an array in the middle of a struct so deferencing it is not a
> problem as long as ctx is not NULL. Eliminate the check, which fixes the
> warning.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists