linux-kernel - Re: [PATCH 1/2] watchdog: iTCO_wdt: use pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210619231933.GA3821829@roeck-us.net>
Date:   Sat, 19 Jun 2021 16:19:33 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     kernel test robot <lkp@...el.com>
Cc:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        linux-kernel@...r.kernel.org, kbuild-all@...ts.01.org,
        wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 1/2] watchdog: iTCO_wdt: use pm_ptr()

On Sun, Jun 20, 2021 at 06:27:52AM +0800, kernel test robot wrote:
> Hi "Enrico,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on linux/master]
> [also build test ERROR on hwmon/hwmon-next linus/master v5.13-rc6 next-20210618]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/watchdog-iTCO_wdt-use-pm_ptr/20210617-024441
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd860052c99b1e088352bdd4fb7aef46f8d2ef47
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/670a790c3acfccf4b5405459048ba2a05b912eef
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/watchdog-iTCO_wdt-use-pm_ptr/20210617-024441
>         git checkout 670a790c3acfccf4b5405459048ba2a05b912eef
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/device.h:25,
>                     from include/linux/acpi.h:15,
>                     from drivers/watchdog/iTCO_wdt.c:48:
> >> drivers/watchdog/iTCO_wdt.c:645:21: error: 'iTCO_wdt_pm' undeclared here (not in a function); did you mean 'iTCO_wdt_ops'?
>      645 |   .pm     = pm_ptr(&iTCO_wdt_pm),
>          |                     ^~~~~~~~~~~
>    include/linux/pm.h:377:23: note: in definition of macro 'pm_ptr'
>      377 | #define pm_ptr(_ptr) (_ptr)
>          |                       ^~~~
> 
> 
> vim +645 drivers/watchdog/iTCO_wdt.c
> 
>    640	
>    641	static struct platform_driver iTCO_wdt_driver = {
>    642		.probe          = iTCO_wdt_probe,
>    643		.driver         = {
>    644			.name   = DRV_NAME,
>  > 645			.pm     = pm_ptr(&iTCO_wdt_pm),

I'll drop this patch for now.

Guenter

>    646		},
>    647	};
>    648	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org