linux-kernel - Re: [PATCH v4 06/16] ipmi: kcs_bmc: Split headers into device and client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210618232417.GB9658@hatter>
Date:   Fri, 18 Jun 2021 23:24:17 +0000
From:   Zev Weiss <zweiss@...inix.com>
To:     Andrew Jeffery <andrew@...id.au>
CC:     "openipmi-developer@...ts.sourceforge.net" 
        <openipmi-developer@...ts.sourceforge.net>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "minyard@....org" <minyard@....org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "tmaimon77@...il.com" <tmaimon77@...il.com>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "avifishman70@...il.com" <avifishman70@...il.com>,
        "venture@...gle.com" <venture@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tali.perry1@...il.com" <tali.perry1@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "chiawei_wang@...eedtech.com" <chiawei_wang@...eedtech.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "benjaminfair@...gle.com" <benjaminfair@...gle.com>,
        "arnd@...db.de" <arnd@...db.de>, "joel@....id.au" <joel@....id.au>,
        "KWLIU@...oton.com" <KWLIU@...oton.com>
Subject: Re: [PATCH v4 06/16] ipmi: kcs_bmc: Split headers into device and
 client

On Tue, Jun 08, 2021 at 05:47:47AM CDT, Andrew Jeffery wrote:
>Strengthen the distinction between code that abstracts the
>implementation of the KCS behaviours (device drivers) and code that
>exploits KCS behaviours (clients). Neither needs to know about the APIs
>required by the other, so provide separate headers.
>
>Signed-off-by: Andrew Jeffery <andrew@...id.au>
>---
> drivers/char/ipmi/kcs_bmc.c           | 23 ++++++++++------
> drivers/char/ipmi/kcs_bmc.h           | 27 +++++++++----------
> drivers/char/ipmi/kcs_bmc_aspeed.c    | 17 ++++++------
> drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 39 ++++++++++++++++++---------
> drivers/char/ipmi/kcs_bmc_client.h    | 27 +++++++++++++++++++
> drivers/char/ipmi/kcs_bmc_device.h    | 19 +++++++++++++
> drivers/char/ipmi/kcs_bmc_npcm7xx.c   | 17 ++++++------
> 7 files changed, 117 insertions(+), 52 deletions(-)
> create mode 100644 drivers/char/ipmi/kcs_bmc_client.h
> create mode 100644 drivers/char/ipmi/kcs_bmc_device.h
>

Reviewed-by: Zev Weiss <zweiss@...inix.com>