linux-kernel - Re: [PATCH] um: remove unneeded semicolon in um

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4320e0ea-1339-e2c1-03c0-271dbcd6e22d@cambridgegreys.com>
Date:   Sat, 19 Jun 2021 07:41:59 +0100
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Wan Jiabing <wanjiabing@...o.com>, Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Johannes Berg <johannes.berg@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Nick Desaulniers <ndesaulniers@...ogle.com>,
        Corey Minyard <cminyard@...sta.com>,
        Thomas Meyer <thomas@...3r.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Joe Perches <joe@...ches.com>, linux-um@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] um: remove unneeded semicolon in um_arch.c

On 19/06/2021 03:02, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./arch/um/kernel/um_arch.c:284:34-35: Unneeded semicolon
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>   arch/um/kernel/um_arch.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> index f9f1463f0521..a149a5e9a16a 100644
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -281,7 +281,7 @@ static void parse_host_cpu_flags(char *line)
>   	int i;
>   	for (i = 0; i < 32*NCAPINTS; i++) {
>   		if ((x86_cap_flags[i] != NULL) && strstr(line, x86_cap_flags[i]))
> -			set_cpu_cap(&boot_cpu_data, i);;
> +			set_cpu_cap(&boot_cpu_data, i);
>   	}
>   }
>   static void parse_cache_line(char *line)
> 

Thanks.

I do not think the patch which introduces this ([v7,1/3] um: Add support 
for host CPU flags and alignment) has been merged yet. I do not see it 
in the tree as of this morning.

I can see that it is already marked as done in patchwork so it is on its 
way.

Richard, what do you want me to do - reissue a fixed one or we should 
accept the fix once the original is merged?

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/