linux-kernel - Re: [PATCH 5.10 35/38] rtnetlink: Fix missing error code in rtnl_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YM2SpRA5lgMNP1W3@kroah.com>
Date:   Sat, 19 Jun 2021 08:45:57 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alexander Tsoy <alexander@...y.me>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        "David S. Miller" <davem@...emloft.net>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.10 35/38] rtnetlink: Fix missing error code in
 rtnl_bridge_notify()

On Sat, Jun 19, 2021 at 02:58:28AM +0300, Alexander Tsoy wrote:
> В Ср, 16/06/2021 в 17:33 +0200, Greg Kroah-Hartman пишет:
> > From: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> > 
> > [ Upstream commit a8db57c1d285c758adc7fb43d6e2bad2554106e1 ]
> > 
> > The error code is missing in this code scenario, add the error code
> > '-EINVAL' to the return value 'err'.
> > 
> > Eliminate the follow smatch warning:
> > 
> > net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
> > 'err'.
> 
> This patch breaks systemd-resolved. It is 100% reproducible on two of
> my systems, but there are also systems where I cannot reproduce it. The
> problem manifests itself as SERVFAIL on every DNS query.
> 
> Just reverting this patch from 5.10.45 fixes the problem for me.

Is Linus's tree also broken for you?  It should be reverted there first.

thanks,

greg k-h