linux-kernel - Re: [PATCH] mlx4_core: Remove trailing semicolon in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9bdb1fd3-8a48-a9aa-8775-7e07dac8d56c@gmail.com>
Date:   Sun, 20 Jun 2021 18:06:53 +0300
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Huilong Deng <denghuilong@...rlc.com>, yishaih@...dia.com
Cc:     linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mlx4_core: Remove trailing semicolon in macros



On 6/20/2021 5:36 PM, Huilong Deng wrote:
> Macros should not use a trailing semicolon.
> 
> Signed-off-by: Huilong Deng <denghuilong@...rlc.com>
> ---
>   include/linux/mlx4/doorbell.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mlx4/doorbell.h b/include/linux/mlx4/doorbell.h
> index f31bba270aa2..e3ecaa4f00fa 100644
> --- a/include/linux/mlx4/doorbell.h
> +++ b/include/linux/mlx4/doorbell.h
> @@ -66,7 +66,7 @@ static inline void mlx4_write64(__be32 val[2], void __iomem *dest,
>    * MMIO writes.
>    */
>   
> -#define MLX4_DECLARE_DOORBELL_LOCK(name) spinlock_t name;
> +#define MLX4_DECLARE_DOORBELL_LOCK(name) spinlock_t name
>   #define MLX4_INIT_DOORBELL_LOCK(ptr)     spin_lock_init(ptr)
>   #define MLX4_GET_DOORBELL_LOCK(ptr)      (ptr)
>   
> 

Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Thanks,
Tariq