linux-kernel - Re: [PATCH 1/4] perf test: Fix non-bash issue with stat bpf counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210621075525.128b476f@canb.auug.org.au>
Date:   Mon, 21 Jun 2021 07:55:25 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Song Liu <songliubraving@...com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH 1/4] perf test: Fix non-bash issue with stat bpf
 counters

Hi Ian,

On Thu, 17 Jun 2021 11:42:13 -0700 Ian Rogers <irogers@...gle.com> wrote:
>
> $(( .. )) is a bash feature but the test's interpreter is !/bin/sh,
> switch the code to use expr.

The $(( .. )) syntax is specified in POSIX (see
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_04),
so unless this caused an actual problem, this change is unnecessary.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped