linux-kernel - Re: [PATCH] coccinelle: api: remove kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc3b2db6-70fd-0bb2-d083-f87f9a35e9a7@linux.com>
Date:   Mon, 21 Jun 2021 21:32:15 +0300
From:   Denis Efremov <efremov@...ux.com>
To:     Keith Busch <kbusch@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Julia Lawall <Julia.Lawall@...ia.fr>
Subject: Re: [PATCH] coccinelle: api: remove kobj_to_dev.cocci script



On 6/21/21 8:48 PM, Keith Busch wrote:
> Using kobj_to_dev() instead of container_of() is not universally
> accepted among maintainers as an improvement. The warning leads to
> repeated patch submissions that won't be accepted. Remove the script.
> 
> Cc: Christoph Hellwig <hch@....de>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Denis Efremov <efremov@...ux.com>
> Cc: Julia Lawall <Julia.Lawall@...ia.fr>
> Signed-off-by: Keith Busch <kbusch@...nel.org>

Acked-by: Denis Efremov <efremov@...ux.com>

> ---
>  scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------
>  1 file changed, 45 deletions(-)
>  delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci
> 
> diff --git a/scripts/coccinelle/api/kobj_to_dev.cocci b/scripts/coccinelle/api/kobj_to_dev.cocci
> deleted file mode 100644
> index cd5d31c6fe76..000000000000
> --- a/scripts/coccinelle/api/kobj_to_dev.cocci
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0-only
> -///
> -/// Use kobj_to_dev() instead of container_of()
> -///
> -// Confidence: High
> -// Copyright: (C) 2020 Denis Efremov ISPRAS
> -// Options: --no-includes --include-headers
> -//
> -// Keywords: kobj_to_dev, container_of
> -//
> -
> -virtual context
> -virtual report
> -virtual org
> -virtual patch
> -
> -
> -@r depends on !patch@
> -expression ptr;
> -symbol kobj;
> -position p;
> -@@
> -
> -* container_of(ptr, struct device, kobj)@p
> -
> -
> -@...ends on patch@
> -expression ptr;
> -@@
> -
> -- container_of(ptr, struct device, kobj)
> -+ kobj_to_dev(ptr)
> -
> -
> -@...ipt:python depends on report@
> -p << r.p;
> -@@
> -
> -coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()")
> -
> -@...ipt:python depends on org@
> -p << r.p;
> -@@
> -
> -coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
>