linux-kernel - Re: linux-next: Fixes tag needs some work in the kvm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbab918a-a6f0-b1d4-90ba-1ab0172b68de@redhat.com>
Date:   Tue, 22 Jun 2021 01:37:29 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>, KVM <kvm@...r.kernel.org>
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the kvm tree

On 22/06/21 00:18, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    ade74e1433f3 ("KVM: x86/mmu: Grab nx_lpage_splits as an unsigned long before division")
> 
> Fixes tag
> 
>    Fixes: 7ee093d4f3f5 ("KVM: switch per-VM stats to u64")
> 
> has these problem(s):
> 
>    - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: e3cb6fa0e2bf ("KVM: switch per-VM stats to u64")
> 
> It is very hard to get the commit SHA right when the commit you are
> "fixing" is after the fix commit :-)

Yeah, that Fixes tag should have been removed since the patch can be 
kept separate (does not have to be squashed).

Paolo