linux-kernel - Re: [PATCH] block: mtip32xx: set the pointer of queue to null after cleaning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhUBj=OH8TOtVrJSfStWT=YWr3=Od=D+-BCtGhX1nN76wOYDA@mail.gmail.com>
Date:   Mon, 21 Jun 2021 15:50:28 +0800
From:   Zheyu Ma <zheyuma97@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     axboe@...nel.dk, liushixin2@...wei.com,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lee Jones <lee.jones@...aro.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        guoqing.jiang@...ud.ionos.com, linux-block@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: mtip32xx: set the pointer of queue to null after cleaning

On Mon, Jun 21, 2021 at 2:16 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Sun, Jun 20, 2021 at 12:19:17PM +0000, Zheyu Ma wrote:
> > When 'mtip_block_initialize' fails at 'mtip_hw_get_identify', a series
> > of cleanup operations will be performed. But when the execution reaches
> > 'put_disk', it will cause refcount underflow. The reason for this error
> > is that after cleaning 'dd->queue', 'dd->disk->queue' was not set to
> > null at the same time, which caused repeated cleanup work.
> >
> > Fix this by set 'dd->disk->queue' to null after cleaning
>
> This should all be fixed by the switch to blk_cleanup_disk and the
> preparation for it in linux-next.

Thanks for your reply, I have switched to the linux-next branch.

Best regards,
Zheyu Ma