linux-kernel - Re: [PATCH rdma-next v2] RDMA: Fix kernel-doc warnings about wrong comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Jun 2021 20:52:29 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Leon Romanovsky <leonro@...dia.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Jack Wang <jinpu.wang@...os.com>,
        Lijun Ou <oulijun@...wei.com>, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, Max Gurtovoy <mgurtovoy@...dia.com>,
        "Md. Haris Iqbal" <haris.iqbal@...os.com>,
        Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
        Sagi Grimberg <sagi@...mberg.me>,
        Weihang Li <liweihang@...wei.com>
Subject: Re: [PATCH rdma-next v2] RDMA: Fix kernel-doc warnings about wrong
 comment

On Wed, Jun 16, 2021 at 09:09:47AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> Compilation with W=1 produces warnings similar to the below.
> 
>   drivers/infiniband/ulp/ipoib/ipoib_main.c:320: warning: This comment
> 	starts with '/**', but isn't a kernel-doc comment. Refer
> 	Documentation/doc-guide/kernel-doc.rst
> 
> All such occurrences were found with the following one line
>  git grep -A 1 "\/\*\*" drivers/infiniband/
> 
> Reviewed-by: Jack Wang <jinpu.wang@...os.com> #rtrs
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> ---
>  Changelog:
>  v1 https://lore.kernel.org/lkml/8b40bbff098247962af5a7b35d47b2e964daa523.1622726066.git.leonro@nvidia.com
>  * Found two extra places in hns_roce_hem.c
>  * Added Dennis's ROB
>  v0 https://lore.kernel.org/lkml/635def71048cbffe76e2dd324cf420d8a465ee9d.1622460676.git.leonro@nvidia.com:
>  * Rebased to drop i40iw
>  * Added Jack's ROB
> ---
>  drivers/infiniband/core/iwpm_util.h       | 2 +-
>  drivers/infiniband/core/roce_gid_mgmt.c   | 5 +++--
>  drivers/infiniband/hw/hfi1/chip.c         | 4 ++--
>  drivers/infiniband/hw/hfi1/file_ops.c     | 6 +++---
>  drivers/infiniband/hw/hfi1/hfi.h          | 2 +-
>  drivers/infiniband/hw/hfi1/init.c         | 4 ++--
>  drivers/infiniband/hw/hfi1/pio.c          | 2 +-
>  drivers/infiniband/hw/hns/hns_roce_hem.c  | 4 ++--
>  drivers/infiniband/sw/rdmavt/mr.c         | 4 ++--
>  drivers/infiniband/sw/rdmavt/qp.c         | 3 ++-
>  drivers/infiniband/sw/rdmavt/vt.c         | 4 ++--
>  drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++---
>  drivers/infiniband/ulp/iser/iser_verbs.c  | 2 +-
>  drivers/infiniband/ulp/isert/ib_isert.c   | 4 ++--
>  drivers/infiniband/ulp/rtrs/rtrs-clt.c    | 4 ++--
>  drivers/infiniband/ulp/rtrs/rtrs-srv.c    | 2 +-
>  16 files changed, 31 insertions(+), 28 deletions(-)

Applied to for-next, thanks

Jason