linux-kernel - Re: [PATCH -next 2/4] ASoC: samsung: pcm: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88808fcb-d89b-9e90-bd5e-c9074f373192@canonical.com>
Date:   Mon, 21 Jun 2021 11:22:43 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Cc:     s.nawrocki@...sung.com, broonie@...nel.org
Subject: Re: [PATCH -next 2/4] ASoC: samsung: pcm: Use
 devm_platform_get_and_ioremap_resource()

On 16/06/2021 11:16, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  sound/soc/samsung/pcm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
> index bfd76e9cc0ca..4c4dfde0568f 100644
> --- a/sound/soc/samsung/pcm.c
> +++ b/sound/soc/samsung/pcm.c
> @@ -512,8 +512,7 @@ static int s3c_pcm_dev_probe(struct platform_device *pdev)
>  	/* Default is 128fs */
>  	pcm->sclk_per_fs = 128;
>  
> -	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	pcm->regs = devm_ioremap_resource(&pdev->dev, mem_res);
> +	pcm->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &mem_res);
>  	if (IS_ERR(pcm->regs))
>  		return PTR_ERR(pcm->regs);
>  
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

Best regards,
Krzysztof