linux-kernel - Re: [PATCH 15/18] staging: rtl8723bs: remove register initializations tied to 802.11ac standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3f7e373-a7f9-f48f-b510-7eb3e56e872e@redhat.com>
Date:   Mon, 21 Jun 2021 11:48:27 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Fabio Aiuto <fabioaiuto83@...il.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 15/18] staging: rtl8723bs: remove register initializations
 tied to 802.11ac standard

Hi,

On 6/19/21 12:47 PM, Fabio Aiuto wrote:
> remove register initializations tied to 802.11ac standard which
> is not supported by the device.
> 
> It's a dangerous operation, relying only on comments, but tested
> on a Lenovo Ideapad MIIX 300-10IBY tablet seems to work.
> 
> Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>

TBH I think this patch should be dropped from the series, you
are dropping a bunch of register writes which likely are actually
doing something, so this is not just dead code removal.

Regards,

Hans


> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index 059d3050acc6..3a03dfb8d275 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -1718,24 +1718,12 @@ void _InitBurstPktLen_8723BS(struct adapter *Adapter)
>  	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
>  
>  	rtw_write8(Adapter, 0x4c7, rtw_read8(Adapter, 0x4c7)|BIT(7)); /* enable single pkt ampdu */
> -	rtw_write8(Adapter, REG_RX_PKT_LIMIT_8723B, 0x18);		/* for VHT packet length 11K */
>  	rtw_write8(Adapter, REG_MAX_AGGR_NUM_8723B, 0x1F);
>  	rtw_write8(Adapter, REG_PIFS_8723B, 0x00);
>  	rtw_write8(Adapter, REG_FWHW_TXQ_CTRL_8723B, rtw_read8(Adapter, REG_FWHW_TXQ_CTRL)&(~BIT(7)));
>  	if (pHalData->AMPDUBurstMode)
>  		rtw_write8(Adapter, REG_AMPDU_BURST_MODE_8723B,  0x5F);
>  	rtw_write8(Adapter, REG_AMPDU_MAX_TIME_8723B, 0x70);
> -
> -	/*  ARFB table 9 for 11ac 5G 2SS */
> -	rtw_write32(Adapter, REG_ARFR0_8723B, 0x00000010);
> -	if (IS_NORMAL_CHIP(pHalData->VersionID))
> -		rtw_write32(Adapter, REG_ARFR0_8723B+4, 0xfffff000);
> -	else
> -		rtw_write32(Adapter, REG_ARFR0_8723B+4, 0x3e0ff000);
> -
> -	/*  ARFB table 10 for 11ac 5G 1SS */
> -	rtw_write32(Adapter, REG_ARFR1_8723B, 0x00000010);
> -	rtw_write32(Adapter, REG_ARFR1_8723B+4, 0x003ff000);
>  }
>  
>  static void ResumeTxBeacon(struct adapter *padapter)
>