linux-kernel - Re: [PATCH v1 1/1] spi: Remove unneeded parentheses in spi_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210621103923.GA4094@sirena.org.uk>
Date:   Mon, 21 Jun 2021 11:39:23 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] spi: Remove unneeded parentheses in spi_map_buf()

On Sat, Jun 19, 2021 at 02:15:26PM +0300, Andy Shevchenko wrote:
> The boolean expression to get kmap_buf is hard to read due to
> too many unneeded parentheses. Remove them for good.

> -	const bool kmap_buf = ((unsigned long)buf >= PKMAP_BASE &&
> -				(unsigned long)buf < (PKMAP_BASE +
> -					(LAST_PKMAP * PAGE_SIZE)));
> +	const bool kmap_buf = (unsigned long)buf >= PKMAP_BASE &&
> +			      (unsigned long)buf < (PKMAP_BASE + LAST_PKMAP * PAGE_SIZE);

No, I think this makes things worse - to the extent there's an issue
here it's not excessive brackets.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)