linux-kernel - Re: [PATCH v4 2/7] iommu/amd: Do not use flush-queue when NpCache is on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91ea2a97-2db6-3e10-9c2e-80f6a4e0f733@huawei.com>
Date:   Mon, 21 Jun 2021 13:37:29 +0100
From:   John Garry <john.garry@...wei.com>
To:     Nadav Amit <nadav.amit@...il.com>, Joerg Roedel <joro@...tes.org>
CC:     Robin Murphy <robin.murphy@....com>,
        <linux-kernel@...r.kernel.org>, <iommu@...ts.linux-foundation.org>,
        Nadav Amit <namit@...are.com>,
        Jiajun Cao <caojiajun@...are.com>,
        Will Deacon <will@...nel.org>,
        Lu Baolu <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH v4 2/7] iommu/amd: Do not use flush-queue when NpCache is
 on

On 16/06/2021 11:04, Nadav Amit wrote:
> -	if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE))
> +	if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) {
> +		if (!amd_iommu_unmap_flush)
> +			pr_warn("IOMMU batching is disabled due to virtualization");

This is missing the '\n', like the Intel driver.

And, JFYI, we are also downgrading that same print to info level (in the 
Intel driver).

Thanks,
John

> +
>   		amd_iommu_np_cache = true;
> +		amd_iommu_unmap_flush = true;